search

SimformSolutionsPvtLtd / flutter_credit_card

A credit card widget for Flutter application.
https://pub.dev/packages/flutter_credit_card
MIT License
417 stars 241 forks source link

Added support for Dart 3 #137

Closed marcoedomingos closed 11 months ago

marcoedomingos commented 1 year ago

In this pr, the sdk was updated for Dart 3, with that the type of expiryDate was changed from a String to a Record, thus allowing to insert only two values, one for the Month and another for the year, thus preventing users to define a text that is not in Expiration Date Format or is not a number.

Also fixed issue #135 by refracting parts of the code and adding ways to prevent the issue from happening.

marcoedomingos commented 1 year ago

@ShwetaChauhan18 ??

marcoedomingos commented 1 year ago

@ShwetaChauhan18 ??

aditya-css commented 11 months ago

@Marco4763 Thank you for your effort in creating this pull request. I appreciate the work you've put into it.

Regarding the changes proposed in the pull request, I understand the intention behind setting the minimum SDK constraint to 3.0.0 and utilizing Dart 3 features such as records. However, setting the minimum SDK constraint to 3.0.0 would render the package unusable for users with Dart versions lower than 3. To ensure inclusivity and accessibility for a wider user base, it would be more beneficial to consider adjusting the maximum constraint instead.