search

Simn / genjvm

13 stars 1 forks source link

Generated constructors #18

Closed Simn closed 5 years ago

Simn commented 5 years ago

typeloadFields.ml has this:

        (* add_constructor does not deal with overloads correctly *)
        if not ctx.com.config.pf_overload then TypeloadFunction.add_constructor ctx c cctx.force_constructor p;

That means that constructors are not auto-generated, which leads to problems. This is handles for genjava through overloadingConstructor.ml, but that thing is pretty gencommon.

I'll probably just enable add_constructor for the time being because constructors with wrong overloads are slightly better than no constructors.

Simn commented 5 years ago

Will be solved as part of #8.