If a source filename has special characters like the combining tilde used in Spanish, migration tool will generate and record a URL-encoded URL for it. For example, señora.jpg => sen%CC%83ora.jpg where CC 83 is the UTF-8 encoding of the combining tilde. However, the Amazon S3 API apparently takes a non-URL-encoded "key" which may be any UTF-8 string. Including special characters may cause trouble for client applications, but is allowed in an S3 key.
The upload tool was generating a key from the encoded URL. The result in the above case is that the URL needed to access the uploaded file would be sen%25CC%2583ora.jpg to match the literal percent characters in the S3 key (and this was the value returned from the API as the data.location). So the generated URLs fail to match the resulting upload location of the file whenever characters requiring URL-encoding are part of the filename.
This changes the code to undo URL encoding when forming the S3 key.
If a source filename has special characters like the combining tilde used in Spanish, migration tool will generate and record a URL-encoded URL for it. For example, señora.jpg =>
sen%CC%83ora.jpgwhere CC 83 is the UTF-8 encoding of the combining tilde. However, the Amazon S3 API apparently takes a non-URL-encoded "key" which may be any UTF-8 string. Including special characters may cause trouble for client applications, but is allowed in an S3 key.The upload tool was generating a key from the encoded URL. The result in the above case is that the URL needed to access the uploaded file would be
sen%25CC%2583ora.jpgto match the literal percent characters in the S3 key (and this was the value returned from the API as the data.location). So the generated URLs fail to match the resulting upload location of the file whenever characters requiring URL-encoding are part of the filename.This changes the code to undo URL encoding when forming the S3 key.