Simon-Initiative / course-digest

Tool to produce a summary or digest of OLI course package contents
MIT License
2 stars 0 forks source link

Migration: Drag and Drop not working in PC Software/ Hardware, Concepts in Computing #199

Closed tanvidomadia closed 1 year ago

tanvidomadia commented 1 year ago

Describe the bug Drag and Drops (DnD) are not working in PC Software/ Hardware and Concepts of Computing ingested courses.

Image in Tokamak (student view):

Screenshot 2023-08-28 at 2 50 54 PM

Image in OLI Legacy:

Screenshot 2023-08-28 at 4 01 49 PM

To Reproduce Steps to reproduce the behavior:

  1. Go to tokamak.oli.cmu.edu as a student
  2. Enroll to the PC Software course section: https://tokamak.oli.cmu.edu/sections/join/mgwc1
  3. Go to page '[Basic Linux commands (https://tokamak.oli.cmu.edu/sections/pcsoftware__0818/page/z6f24_basic_linux_commands_e9tfz)'
  4. See error

Expected behavior The drag and drops work in the legacy version of the courses as seen in the screenshots above.

Screenshots Some more screenshots of DnD errors are as follows:

  1. Tokamak version versus Legacy OLI:

    Screenshot 2023-08-28 at 2 51 04 PM Screenshot 2023-08-28 at 4 01 56 PM
  2. Tokamak version versus Legacy OLI:

    Screenshot 2023-08-28 at 4 05 03 PM Screenshot 2023-08-28 at 6 32 10 PM

Environment:

Additional context More drag and drop errors can be found in the following courses by clicking on the 'All Activities' link on the Authoring version of the course:

  1. PC Hardware: 19 DnD activities

  2. PC Software: 3 DnD activities

  3. Concepts in Computing: 3 DnD activities

andersweinstein commented 1 year ago

Found two distinct issues affecting the drag-and-drops in these courses: (1) DND custom style-sheets use id-qualified styles which will not work in torus because no parent element will have the relevant id; and (2) some use images as initiators and/or the target table, and these are cases which migration tool has not handled.

There is a PR for the digest tool with fixes for both issues.

eliknebel commented 1 year ago

Fixed in course-digest tool