Simon-Initiative / course-digest

Tool to produce a summary or digest of OLI course package contents
MIT License
2 stars 0 forks source link

[BUGFIX] Fixes for missing questions, targeted feedback, title handling #34

Closed darrensiegel closed 2 years ago

darrensiegel commented 2 years ago

This PR fixes several issues that were observed during the QA phase of the Pcard and GUSIO courses.

  1. https://github.com/Simon-Initiative/oli-torus/issues/2449 - Fixes title handling by converting <title> elements of tables and media elements to <h5> elements preceding the table or media element. There is not a problem with the display of paragraphs within tables. The specific example cited in this bug is from a legacy page that contained a table within a list item. This is not supported in Torus. Tables are top level block elements.
  2. https://github.com/Simon-Initiative/oli-torus/issues/2446 - After generation of a digest and local ingest, images from supporting content seem to be rendering fine now.
  3. https://github.com/Simon-Initiative/oli-torus/issues/2445 - Fixed by properly handling the shuffle attribute.
  4. https://github.com/Simon-Initiative/oli-torus/issues/2444 - Fixed by handling an edge case where there are only two choices and neither use the "catch all" rule.
  5. https://github.com/Simon-Initiative/oli-torus/issues/2455 - Fixed, the issue here is that the course-digest tool was treating question identifiers as globally unique to a course. In Echo courses these ids are guids, which allow them to be globally unique, but in hand crafted courses there is no guarantee that these ids are globally unique. In this course almost every formative and summative used the same question identification strategy: mcq1, mcq2, mcq3, etc. This caused overwriting internally of these reused question ids, which lead to questions being dropped and in the case of formatives, questions appearing referenced from the wrong page.
  6. https://github.com/Simon-Initiative/oli-torus/issues/2453 - Fixed, same root case as number 5.
  7. https://github.com/Simon-Initiative/oli-torus/issues/2454 - Fixed, targeted feedback was not being set up correctly.