search

Simon-Initiative / course-digest

Tool to produce a summary or digest of OLI course package contents
MIT License
2 stars 0 forks source link

fix an issue where the pipe char is invalid filename character on windows platforms #42

Closed eliknebel closed 2 years ago

eliknebel commented 2 years ago

This PR fixes an issue where the pipe char is an invalid filename character on windows platforms. The fix here is to add the parentId to the Objective resource object and use '-' for concatenations when keying for maps.

Tested on Windows 10 using the following in command prompt:

ts-node src/index.ts "--operation" "convert" "--inputDir" ".\\test\\course_packages\\migration-4sdfykby_v_1_0-echo" "--specificOrg" "test\\course_packages\\migration-4sdfykby_v_1_0-echo\\organizations\\default\\organization.xml" "--specificOrgId" "migration-4sdfykby-1.0_default" "--outputDir" ".\\out" "--mediaUrlPrefix" "https://torus-media.s3.amazonaws.com/media"