search

Simon-Initiative / oli-torus

Next Generation OLI Authoring and Delivery Platform
https://proton.oli.cmu.edu
MIT License
83 stars 35 forks source link

Labels running into targets in Drag and Drops #3447

Closed sandyraysor closed 2 weeks ago

sandyraysor commented 1 year ago

https://proton.oli.cmu.edu/sections/gen_chem_0427_default_org_4gfjy/page/8i2pe_application_is_it_gold_u9j3q

image

image

andersweinstein commented 1 year ago

This question uses a custom layout spec which is not table based, but simply positions each element (label and target area) absolutely in its container. I assume the fixed positions were custom-chosen to work with the legacy font. This layout method is not adaptive to a change in font. But the layout does not specify any font or font size so picks up the ambient default which is now different than the one it was customized for. This will be a general issue with migrating custom-tweaked layouts like this one.

Layout could be modified to change positions for torus, or specify a font to use (but might clash visually), But best would be to use a more adaptive layout method like a tabular one.

darrensiegel commented 1 year ago

Task here is to emit a warning in the digest tool when encountering a DnD question with absolute positioning within the CSS

darrensiegel commented 1 year ago

https://eliterate.atlassian.net/browse/MER-1997

andersweinstein commented 1 year ago

Note absolute positioning is fine if used solely to position target boxes with respect to a background image, as done in at least one chem question. So there could be a lot of "false positives" from this warning.

Also, the starter drag and drop you get by authoring a new one in torus uses absolute positioning of text labels in the style of this question.