search

Simon-Initiative / oli-torus

Next Generation OLI Authoring and Delivery Platform
https://proton.oli.cmu.edu
MIT License
83 stars 35 forks source link

[BUG FIX] [NG23-185] My assignments in Homepage fixes #4854

Closed gastonabella closed 3 months ago

gastonabella commented 3 months ago

NG23-185

The second PR for implementing the new My Assignments box on the student's homepage (the first was https://github.com/Simon-Initiative/oli-torus/pull/4834).

It addresses several bug fixes (further details on the ticket):

  1. The student has to complete at least one attempt for the assignment to appear on the “Latest” tab. The assignment does not appear on the “Latest” tab if the user is on their first attempt. FIXED ✅
  2. The number of attempts is always shown as 1. FIXED ✅
  3. The score on the card differs from what the student and the instructor see when looking at the attempts. FIXED ✅
  4. The max. number of attempts is always the value of the revision, and it should also consider the configured settings. FIXED ✅
  5. There is no change in the card when the student has completed all attempts for an assignment. FIXED ✅
  6. The time remaining differs from the time limit set by the instructor.

This last one is not considered a bug, since it's using the same logic being used in other parts of Torus to calculate the time remaining for an assignment (diff between now and the resource end date). It needs product definition and will be addressed on a separate PR.