search

Simon-Initiative / oli-torus

Next Generation OLI Authoring and Delivery Platform
https://proton.oli.cmu.edu
MIT License
81 stars 35 forks source link

[BUG FIX] [NG23-246] Content on page is not visible on begin attempt #4895

Closed nicocirio closed 1 month ago

nicocirio commented 1 month ago

Link to the ticket

The issue was that the required scripts to "decode" the React component into HTML were not correctly provided. To fix it, we finally separated the prologue page into a new Liveview and do a redirect to the lesson page when the student clicks on "Begin Attempt".

Note: Besides the new RedirectToPrologue live session plug and the router minor change, most of the PR involved moving code from the lesson_live.ex to the new prologue_live.ex, including its tests.

Before

https://github.com/Simon-Initiative/oli-torus/assets/74839302/e9e4b9f4-4121-4c93-b0ec-f6b41117becc

After

https://github.com/Simon-Initiative/oli-torus/assets/74839302/6294e305-6666-4110-9164-37baba88261f

nicocirio commented 1 month ago

Nice catch @darrensiegel , thanks! I have added a new live_session plug to redirect to the lesson page when there is an attempt in progress:

https://github.com/Simon-Initiative/oli-torus/assets/74839302/438dda12-e4c9-4724-aadc-59ac7284eee8