Simon-Initiative / oli-torus

Next Generation OLI Authoring and Delivery Platform
https://proton.oli.cmu.edu
MIT License
78 stars 35 forks source link

[BUG FIX] [MER-3202] change ingested activity scoring strategy to "total", not "average" #4913

Closed andersweinstein closed 2 weeks ago

andersweinstein commented 2 weeks ago

All ingested activities were getting a hardcoded default scoring strategy of "average". This caused unexpected and undesired behavior on multi-input questions in migrated/ingested courses. For example, on a two-part question with the default 1 point per part, the score for two correct answers would be 1 out of 1, when instructors expect 2 out of 2. This PR corrects the code to set the "total" scoring strategy on ingested activities, which is the natural default. That is also the default applied elsewhere in the code, for example to newly created activities and on updates setting default scoring strategy (see maybe_update_scoring_strategy).

The main is use for ingestion of migrated courses. The strategy remains changeable after ingestion through custom scoring interface in the unlikely event something different is wanted for activity-level scoring.