Simon-Initiative / oli-torus

Next Generation OLI Authoring and Delivery Platform
https://proton.oli.cmu.edu
MIT License
78 stars 35 forks source link

[BUG FIX] [NG23-259] Custom container labels not honored on Learn Page #4930

Closed nicocirio closed 1 week ago

nicocirio commented 2 weeks ago

Link to the ticket

With this fix container labels are correctly shown on the Learn Page.

https://github.com/Simon-Initiative/oli-torus/assets/74839302/01a813fc-95e9-4b7d-9c7d-55e39baea407

I also checked that all the other pages -Home, Schedule, etc- display container labels correctly.

While working on the ticket I realized that when the instructor changed the container labels, the new values weren't updated on the student delivery pages (I needed to restart the server to see the updated values). This was because some section fields, including the labels, are cached. To fix this the SectionCache module was updated to clear the desired cache keys.

Suggestion: Instructors can edit labels for "Unit", "Module" and "Section". Since our new NG UI renders some other labels -such as "Page", "Intro", "Explorations", etc- we should consider creating a ticket to expand the custom labels to consider those values.

image