Simon-Initiative / oli-torus

Next Generation OLI Authoring and Delivery Platform
https://proton.oli.cmu.edu
MIT License
78 stars 35 forks source link

[BUG FIX] [NG23-266] Unable to create a notes from learn page #4946

Closed nicocirio closed 1 week ago

nicocirio commented 1 week ago

Link to the ticket

The bug was introduced in NG23-253, where some values needed for the annotation features were accidentally erased from the socket (the mentioned PR temporarily assigned the page_context into the socket). The fix involved assigning to the socket those needed values, to handle all the user interaction with the annotations panel correctly.

After

https://github.com/Simon-Initiative/oli-torus/assets/74839302/f792dadc-d341-467f-9649-fc73d147f6b4

Bug on clearing search after changing selected tab

While working on the fix another bug was found, where after clearing a note search the notes rendered didn't match the selected tab. The steps to reproduce the bug are:

  1. Search for some text while being on "My notes".
  2. Switch to the "Class Notes" tab while keeping the search.
  3. Clear the search -> "My notes" posts will be shown instead of the "Class notes" ones.

Before

https://github.com/Simon-Initiative/oli-torus/assets/74839302/6af232f6-698d-4cff-bce7-84ad041b784e

After

https://github.com/Simon-Initiative/oli-torus/assets/74839302/cd52f402-8eb7-413c-8573-be772181fe4b