Simon-Initiative / oli-torus

Next Generation OLI Authoring and Delivery Platform
https://proton.oli.cmu.edu
MIT License
83 stars 35 forks source link

[BUG FIX] [MER-3500] When editing feedback if a component is selected when using the backspace on the keyboard it will try to delete the component #4978

Closed dtiwarATS closed 1 month ago

dtiwarATS commented 1 month ago

Hey @bsparks could you please look at the PR. Thanks

eliknebel commented 1 month ago

@dtiwarATS can you pull latest in from master please? This includes a fix so that CI will pass

gitguardian[bot] commented 1 month ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [10034199](https://dashboard.gitguardian.com/workspace/76369/incidents/10034199) | Triggered | Generic Password | d1d57c5ca139175d16b7e0c1a6957b3eb9567f0e | config/hound.exs | [View secret](https://github.com/Simon-Initiative/oli-torus/commit/d1d57c5ca139175d16b7e0c1a6957b3eb9567f0e#diff-fee31282487e6c0cc91a1b2da8c3110f34fa650a8b8f4d8e8ac2b6e0edb1c15fR74) | | [10034199](https://dashboard.gitguardian.com/workspace/76369/incidents/10034199) | Triggered | Generic Password | 6ca1172cde3cf5ca0e9e665752b7551935682f66 | .devcontainer/docker-compose.yml | [View secret](https://github.com/Simon-Initiative/oli-torus/commit/6ca1172cde3cf5ca0e9e665752b7551935682f66#diff-67a4805fdcc6145d7b3ada2a6099a9b2e91c9d0fd108c22f95d2f01d219793d1L31) | | [10034199](https://dashboard.gitguardian.com/workspace/76369/incidents/10034199) | Triggered | Generic Password | cd10a32ec1a398070ea2dea4e77c333f069df1aa | config/hound.exs | [View secret](https://github.com/Simon-Initiative/oli-torus/commit/cd10a32ec1a398070ea2dea4e77c333f069df1aa#diff-fee31282487e6c0cc91a1b2da8c3110f34fa650a8b8f4d8e8ac2b6e0edb1c15fR74) | | [10034199](https://dashboard.gitguardian.com/workspace/76369/incidents/10034199) | Triggered | Generic Password | f0f8ee854ea797f4ddce2b983a5294ea64dacba3 | config/dev.exs | [View secret](https://github.com/Simon-Initiative/oli-torus/commit/f0f8ee854ea797f4ddce2b983a5294ea64dacba3#diff-4f36118d05999cec87dec4895c8202881ba0577dc80fba4050aa50bbe9e326b3R45) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

dtiwarATS commented 1 month ago

Hey @eliknebel changes are done. Thanks