Closed nicocirio closed 3 weeks ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Exceptional job @nicocirio ⭐
I found a few issues not related to this ticket, but they are worth mentioning:
- There is an overflow issue that occurs when an email exceeds the width of the menu (see the attached image below).
- The Link a different account link directs to the
link_account
endpoint, but when attempting to change the account, it doesn't work and doesn't apply the change.@eliknebel Do you think it would be possible to create some tickets for that?
Link to the ticket
This PR also updated the 2 skipped tests on https://github.com/Simon-Initiative/oli-torus/pull/4987, and updated the routes from
/sections/workspace
to/workspaces
as asked in this commentLinking when registering
https://github.com/user-attachments/assets/2a7f19de-bd26-417b-8009-e50fba4cfa80
Linking when signing in
https://github.com/user-attachments/assets/a8f2c945-82fb-493a-8af7-5e4f24afdccd
Already linked account
Note that the "Create Account" button on course author is not shown.
https://github.com/user-attachments/assets/7558d803-3559-491a-9e3f-e671278c54d4
Admin login
In all workspaces, the admin account is shown on the user menu (even if a user account is also logged in). Note that, when signing out, the user account (if any) remains logged in. And note that both instructor and student workspaces are not yet developed for the admin user.
https://github.com/user-attachments/assets/0d77f631-c5b9-497c-b078-d65055e06d6d
User menu when logged as instructor
https://github.com/user-attachments/assets/41f0032a-5500-4b24-affa-b7ab81e76114
User menu when logged as author and instructor (or student) simultaneously
https://github.com/user-attachments/assets/f3fee744-4790-46bd-b858-8713a501c1d5
Sign in and Signout
Note that in all cases, the user is redirected back to the workspace where the action (sign-in or sign-out) was triggered
https://github.com/user-attachments/assets/32a51a1f-a033-4fd1-b4f3-d6274698e5a5