Simon-L / ModScript

10 stars 1 forks source link

ID reported by helper is not the correct ID to use for scripting. #9

Open jpnielsen opened 11 months ago

jpnielsen commented 11 months ago

Please see

https://community.vcvrack.com/t/modscript-using-scripts-for-a-better-and-richer-integration-with-midi-controllers-beta-soon/18197/44?u=jens.peter.nielsen

jpnielsen commented 11 months ago

got it working

$ diff LuneHelper.cpp LuneHelper.cpp.new
89c89
<                       sprintf(hexID, "0x%lx", hoveredModule);
---
>                       sprintf(hexID, "0x%llx", hoveredModule);
147c147
<                               moduleIdLabel->text = string::f("0x%lx", (int64_t)hoveredModule);
---
>                               moduleIdLabel->text = string::f("0x%llx", (int64_t)hoveredModule);
224c224

now shows the correct module ID

image
Simon-L commented 11 months ago

I believe this is fixed in 4039314 thanks so much!

jpnielsen commented 11 months ago

Thank you.

"Lune" and "Pleine Lune" also incorrectly show only the lower 32 bits of the ID in their right click menu. I did not know how to fix this, and lunehelper was enough for me.