Proof reading always runs and has unintended(?) behavior

LemonIllusion commented 4 years ago

The DOM changes by proof reading causes different styling (font, capitalization) for article headings (and more?).
There is no way to prevent this because the condition for the operation is too lenient and does not care about the setting for proofreading articles. Here's a screenshot of with/without (left/right) BSC running: In the block below, isReadingEditorialContent should probably be along the lines of (isReadingEditorialContent && Preferences.get(P.advanced._.proofread_articles) !== Proofreading.Options.NEVER). Or I'm in the wrong bit of code altogether. I've not verified anything.
```
operation({
    description: "perform proofreading processing",
    condition: () => isReadingEditorialContent || (isInEditMode && Preferences.get(P.advanced._.proofread_forum_posts)),
    action: Proofreading.performProcessing,
    deferUntil: DOMCONTENTLOADED,
}),
```

SimonAlling commented 4 years ago

Nice catch! I'm on it.

SimonAlling commented 4 years ago

Note to self: related to and perhaps semi-blocked by the planned incorporation of @alling/better-sweclockers-lib into Better SweClockers. Hotfix needed though; this is not acceptable.

SimonAlling commented 4 years ago

Will keep this open so I don't forget about it.

SimonAlling / better-sweclockers

Proof reading always runs and has unintended(?) behavior #152