SimonAlling / better-sweclockers

Better SweClockers
MIT License
11 stars 4 forks source link

Remove obsolete dark theme features #259

Closed SimonAlling closed 11 months ago

SimonAlling commented 11 months ago

On 2023-11-15, the hopes and dreams of an entire community finally came true: a native dark mode was at last introduced by SweClockers, 4290 days after Blargmode released his legendary contribution and 2042 days after Soitora took up the torch.

👉 https://www.sweclockers.com/artikel/37572-antligen-halebop-fixar-morkt-tema-pa-sweclockers 👉 https://www.sweclockers.com/forum/trad/1089561-ett-morkt-tema-till-sweclockers 👉 https://www.sweclockers.com/forum/trad/1515628-sweclockers-dark-ett-modernt-morkt-tema

Applying a custom dark theme via Better SweClockers must thereby be considered obsolete, or at the very least not worth the maintenance burden anymore.

The auto feature could arguably still be useful, but it would need to be heavily modified to work with the native dark mode. Also, unlike BSC, SweClockers can be configured to honor the light/dark scheme setting of the OS, which is probably a Better Way to automate that behavior.

Removing the dark theme toggle fixes this error, caused by the removal of the native menu lock toggle in the Dark Mode update:

Could not insert dark theme toggle on this page:

  https://www.sweclockers.com/

These dependencies were not found:

  menuLockToggle: #menuLock