SimonBiggs / scriptedforms

Quickly create live-update GUIs for Python packages using Markdown and simple HTML elements.
Apache License 2.0
509 stars 34 forks source link

Implement ag-grid #106

Closed SimonBiggs closed 6 years ago

SimonBiggs commented 6 years ago

https://github.com/handsontable/angular-handsontable/blob/master/README.md

SimonBiggs commented 6 years ago

https://handsontable.com/features

SimonBiggs commented 6 years ago

@robmarkcole what do you think about this?

robmarkcole commented 6 years ago

Can you copy-paste into those tables?

SimonBiggs commented 6 years ago

I don't know...

SimonBiggs commented 6 years ago

They have interactive demos on their site. Give it a try? I'm on my mobile at the moment.

robmarkcole commented 6 years ago

Copy paste is there - need to check its not restricted to the pro tier https://docs.handsontable.com/0.36.0/CopyPaste.html?_ga=2.33149565.215781205.1519851621-1740677816.1519851621

image

SimonBiggs commented 6 years ago

I looked through the pro tier, there was no copy paste on that tier.

robmarkcole commented 6 years ago

My personal inclination is to steer away from anything that isn't fully open source

SimonBiggs commented 6 years ago

Handson tables CE has copy paste, and that is open source.

SimonBiggs commented 6 years ago

So what do you think? Worth giving it a shot?

robmarkcole commented 6 years ago

I think so. Tables are bread and butter so worth making them look decent

SimonBiggs commented 6 years ago

Initially I would aim to strip down as much as possible, including only the bare minimum. As time goes on we can work out what features should be enabled that don't make things too complex.

SimonBiggs commented 6 years ago

For me, if it makes adding new pandas rows and columns easier that is great. Also simply fitting more in the page, and lastly the ability to already have things like check boxes etc within the table.

I had a case where I needed to have a variable list of checkboxes allowing users to disable certain items in a list. This sort of thing might hit the spot of those needs with minimal coding effort on my behalf.

robmarkcole commented 6 years ago

Agreed. If people want a complex package those tools already exist. Beauty and simplicity should be the selling points of scriptedforms

SimonBiggs commented 6 years ago

Use ag-grid instead of handson table

Their first example at the following:

https://www.ag-grid.com/?utm_source=webpack&utm_medium=banner&utm_campaign=sponsorship

Is using material design, which fits in much nicer with the theme of the forms.

Here are some comparisons between differing grids:

https://github.com/AmitMY/grids

SimonBiggs commented 6 years ago

ag-grid looks absolutely amazing! ... okay, that's what I am going to use instead.

SimonBiggs commented 6 years ago

Ahh... copy/paste in ag-grid is enterprise only... @robmarkcole were you massively keen on the copy paste feature?

robmarkcole commented 6 years ago

Yes from my experience people will definitely want to copy-paste from excel sheets

SimonBiggs commented 6 years ago

Handsontables doesn't look like it handles printing necessarily well:

https://github.com/handsontable/handsontable/issues/2342

However ag-grid has an option that by default renders it ready for printing:

https://www.ag-grid.com/javascript-grid-for-print/

... I think unfortunately being able to print the table is more important than the copy/paste feature...

robmarkcole commented 6 years ago

I have to say we really want both. If copy-past is to be added down the line that us OK too

SimonBiggs commented 6 years ago

Another thought, have used xlwings before? If a particular form needs close interaction with excel, combining it with xlwings could be a perfect match. Even better than copy paste or API...

robmarkcole commented 6 years ago

I've used xlwings a bit. The only catch is people need python and it installed, so no good for sharing with non python colleagues. How do you proposed to integrate?

SimonBiggs commented 6 years ago

See #2

robmarkcole commented 6 years ago

@SimonBiggs another option for tables http://holoviews.org/user_guide/Tabular_Datasets.html

SimonBiggs commented 6 years ago

Could you try installing the jupyterlab bokeh extension and seeing if bokeh works out of the box? You might get holoviews then as well...

On Tue., 6 Mar. 2018, 5:13 am Robin, notifications@github.com wrote:

@SimonBiggs https://github.com/simonbiggs another option for tables http://holoviews.org/user_guide/Tabular_Datasets.html

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/SimonBiggs/scriptedforms/issues/106#issuecomment-370509104, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQVezCM6ruMvBKY88oCPEHzDDJmZvifks5tbX6tgaJpZM4SXWJn .

robmarkcole commented 6 years ago

@SimonBiggs I would try at work but installing anything via a package manager is a right nightmare. If there was a way to bundle all the required dependencies into a .zip file that anyone could download without using a package manager that would be a real help

SimonBiggs commented 6 years ago

Sure. All good :) Let's not worry about that just yet.

SimonBiggs commented 6 years ago

erghh... ag-grid is not what I want to use.

I'll stick with the angular material grid. Will have to implement elements myself.