Closed 23pointsNorth closed 2 years ago
Base: 95.25% // Head: 95.25% // No change to project coverage :thumbsup:
Coverage data is based on head (
94cc254
) compared to base (a8b799c
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hello @23pointsNorth,
thanks for the quick fix!
I am not sure why the 3.5 and 3.6 test run failed, but I will look into this. My local tests and remote tests look good. I just released v1.2.3 with the included fix for python 3.11, so that we can use it for the Hyperactive tests later.
The issue originated from https://github.com/SimonBlanke/Hyperactive/pull/58 can be summarized around seeding pyhton seeds with non pytonic values. At it's core it is as follows:
Thus, with the new requirements for python 3.11 to accept python types, we can convert the
numpy int
to a pythonicint
.The python 3.11 job succeeds - https://github.com/23pointsNorth/Gradient-Free-Optimizers/actions/runs/3427292210/jobs/5710490773 though some issues with 3.5/6 are flagged, but I am unsure if they are related to this change or how python versions are selected from here
Hope this help (the rabbit hole at https://github.com/holoviz/param/issues/602 was interesting, but hopefully the fix here would be much simpler).