SimonBrazell / privacy-redirect

A simple web extension that redirects Twitter, YouTube, Instagram & Google Maps requests to privacy friendly alternatives.
GNU General Public License v3.0
1.97k stars 114 forks source link

De-AMP links tainted by Google #35

Open Gymcap opened 4 years ago

Gymcap commented 4 years ago

As many know, Googles attempt to rehost websites and normalize the AMP framework is a threat to not only our privacy, but the open internet as a whole.

It would be nice to have the extension make this a non-issue by automatically de-amp-ing any tainted links I happen to click on.

SimonBrazell commented 4 years ago

Hi @Gymcap I can certainly look into it, do you have some examples of an AMP and de-Amp'd links I can look at?

cloudrac3r commented 4 years ago

https://www.daniel.priv.no/web-extensions/amp2html.html

https://github.com/da2x/amp2html

SimonBrazell commented 4 years ago

Thanks for the links @cloudrac3r, this feature seems like a worthy addition to the extension.

seniorm0ment commented 4 years ago

+1 to this, Fuck AMP. Although I do believe uBlock can redirect AMP, I could be wrong. Worth noting though.

DJCrashdummy commented 4 years ago

perhaps worth mentioning here: Redirect AMP to HTML


sorry for bothering, haven't checked the other links mentioned above. :facepalm:

SimonBrazell commented 4 years ago

Thanks, I want to do this and some of the other suggestions but I have no time lately unfortunately, maybe next month.

DJCrashdummy commented 4 years ago

please @SimonBrazell, absolutely no pressure!

as written, i just thought it may be worth mentioning it (to take ideas/code or even show it to other interested users), although i should have taken a better look at already posted links! :stuck_out_tongue_winking_eye:

but still i'm not 100% sure if it is a good idea to pack additional functions into this one addon as mentioned at https://github.com/SimonBrazell/privacy-redirect/issues/43#issuecomment-627383827. :thinking:

cloudrac3r commented 4 years ago

I also think that since amp2html already exists as an extension, there's no need to copy its behavior into this extension. We can just do one thing and do it well.

SimonBrazell commented 4 years ago

@cloudrac3r makes a good point, if there is already an existing extension that is actively maintained then perhaps we shouldn't over complicate things here? I can see it targets all major browsers too so there doesn't seem to be any gaps that we can fill.

polzon commented 4 years ago

To play devil advocate here: I would rather have an all-in-one extension, rather then two extensions. Currently I'm able to replicate most of Privacy Redirect's functions using just the HTTPS-Everywhere extension, but stick with it since it provides a lot of convenience, like toggling specific redirect on and off.

Also, as a user, installing more extensions into my browser adds additional attack surface leaving me more potentially vulnerable. In theory, it's easier for me to audit one extension the two.

In my opinion, an AMP redirect still fits under the category of privacy redirection, so I'd love it if I could have that all in one extension. I don't think adding De-AMP would go against the project goal of "doing one thing well".

theotheroracle commented 4 years ago

on the other hand it makes extensions more modular and lets users pick what functionality they want from different extensions