SimonBrazell / privacy-redirect

A simple web extension that redirects Twitter, YouTube, Instagram & Google Maps requests to privacy friendly alternatives.
GNU General Public License v3.0
2.02k stars 112 forks source link

Add more bibliogram instances #90

Closed tiotrom closed 4 years ago

tiotrom commented 4 years ago

Here are a few of them https://git.sr.ht/~cadence/bibliogram-docs/tree/master/docs/Instances.md - right now the one that's default almost never works. Cheers!

tiotrom commented 4 years ago

Well I didn't realize there are many instances since the menu doesnt work well in the settings. If you click the menu you should see a drop-down of all instances, instead you only see the current instance. Only after you delete (as in delete the text) from the drop down form, it may work to display the instances, but at times it does not. So, I strongly suggest you to improve that. I am doing webdesign for 15 years now and I am a very online oriented creature testing apps, operating systems and the like. If I failed to see that there are more than one instances, I am sure others do too. Peek 2020-08-24 14-36

SimonBrazell commented 4 years ago

So, I strongly suggest you to improve that. I am doing webdesign for 15 years now and I am a very online oriented creature testing apps, operating systems and the like.

Hi @tiotrom you may have noticed there hasn't been much activity on this repo lately, I'm pretty short on time of late, very busy with other dev work, and would appreciate some help with features like this and others if you're interested?

I originally used the built in HTML datalist to provide this feature, however I discovered that the add-on preferences pages don't support datalist for some reason... so I had to roll my own solution, basically emulating the functionality of a native datalist, which includes a search feature. It is this search feature that narrows down the list based on what is currently in the input field, so when there is a URL already in there it only shows others that match that one, which is what is causing this problem.

I think the code could be slightly modified to only show the narrowed down list when the user types something, and show the full list on the initial click instead?

tiotrom commented 4 years ago

I think the code could be slightly modified to only show the narrowed down list when the user types something, and show the full list on the initial click instead?

I think that would be the best.

Hi @tiotrom you may have noticed there hasn't been much activity on this repo lately, I'm pretty short on time of late, very busy with other dev work, and would appreciate some help with features like this and others if you're interested?

Unfortunately I do not know how I can help. I am doing mostly webdesign, the design part, not the coding part...

SimonBrazell commented 4 years ago

Unfortunately I do not know how I can help. I am doing mostly webdesign, the design part, not the coding part...

Oh right, no worries I'll see what I can do.

tiotrom commented 4 years ago

In any case you created a wonderful addon. We made a custom Linux distro TROMjaro, and we are adding such things to our distro by default so I am testing this addon to see if it is reliable enough to add it as default. I wish I could help. Others who are involved with TROMjaro are too buys with other things .... but I am here to test stuff.

SimonBrazell commented 4 years ago

I need to do a build to address the shutdown of invidio.us in the next few days so I'll see if I can do something about the preferences while I'm at it.

tiotrom commented 4 years ago

Sounds great!

SimonBrazell commented 4 years ago

Okay I think I've addressed the issue with dropdown selects now, just to be clear was this the reason you reported the lack of instances? Or do you still want more instances added now that you found them?

SimonBrazell commented 4 years ago

Same goes for the other instance related issues you've opened. I'll wait before releasing this latest change just in case.

tiotrom commented 4 years ago

Awesome! Yes this was the reason I reported. I didn't realize there are many of them. Thanks a lot! Great job

SimonBrazell commented 4 years ago

Oh great, no worries I'll push these changes live now.

tiotrom commented 4 years ago

Wonderful!