Sanjay Review Ticket Week 4 - Githubissues

SimonBrunzell / flask_portfolio

Tri 1: Python and Flask Intro

0 stars 1 forks source link

Sanjay Review Ticket Week 4 #47

Closed SanjayB06 closed 2 years ago

SanjayB06 commented 2 years ago

Attendance
- Ask questions for confusing issues (Jekyll navbar for contributions)
About Page + 0.5
- About page has 2 APIs
- Links to scrum board, commmits
- Changing themes that user can control
- Themes are stored and saved
Analytics
- Branch With Commits
CB Progress + 0.25
- Link to Week 4
Expertise + 1
- Blueprints 0.25
- Jekyll 0.5
- Jekyll Navbar consistent across all pages
- Search on Navbar formatting 0.25

Live Review

Discussed matters:

Procedures: JS procedure to change theme
- note: JS has feature to randomly select from list
Blueprint: subjects page is blueprint
Jekyll: all pages have consistent layout + navbar
Search formatting on navbar present
- note: table layout with consistent grid lines is preferable: wrap all text
Github policy: merging, branching, and pull requests are all taking place. Merge conflicts are being avoided, and if present, being easily resolved.

Recommended Score: 4.75