Fix winget version parsing logic

SimonCropp / WinDebloat

A dotnet tool that removes the bloat in Windows

MIT License

430 stars 24 forks source link

Fix winget version parsing logic #59

Closed benjiro closed 11 months ago

benjiro commented 11 months ago

Winget follows semver versioning so if the target system has a preview or canary build installed say "1.5.2782-preview" System.Version will fallover (https://github.com/dotnet/runtime/issues/19317)

To handle this scenario just drop the prerelease tags from the semver version tag. The prerelease tag isn't really important for WinDebloat to enforce a min version.

SimonCropp commented 11 months ago

can u add a test that verfies this change

benjiro commented 11 months ago

@SimonCropp I've added a couple of tests let me know if your happy with the approach 👍🏻

SimonCropp commented 11 months ago

looks good. i will deploy now