Closed rafaqz closed 1 year ago
I've given up on it, to be honest 😅
Yeah, this is totally just for ModelParameters.jl parameters to work in more places like Distributions.jl.
The number system could have been better designed... I feel like whatever trash we have here is evidence for the case come 2.0 😂
Codecov is borked
Otherwise this is good to merge
Merging #21 (50487cf) into master (c8508a5) will increase coverage by
0.50%
. The diff coverage is47.93%
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 47.58% 48.08% +0.50%
==========================================
Files 3 3
Lines 868 1699 +831
==========================================
+ Hits 413 817 +404
- Misses 455 882 +427
Files Changed | Coverage Δ | |
---|---|---|
src/generator_script.jl | 0.00% <0.00%> (ø) |
|
src/AbstractNumbers.jl | 28.00% <22.22%> (+4.00%) |
:arrow_up: |
src/overloads.jl | 49.63% <48.78%> (-0.81%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I guess you should have all rights to merge & tag this, right?
Yeah will do
Actually it wants signed commits now? Could you relax that a little in the settings?
Done
Closes #20
The ambiguities on
Real
are pretty painful, and there seem to be some new ones onNumber
Maybe better to give up on anything like this working at all...