search

SimonDanisch / Bonito.jl

Serving JS to the browser
MIT License
214 stars 31 forks source link

Iframe resize fixes #134

Closed frankier closed 1 year ago

frankier commented 1 year ago

Currently iframe resizing isn't working well when there are multiple iframes on one page. This PR cleans up the iframe resize script injected into the host page and makes it a bit more robust.

frankier commented 1 year ago

This helps with running on binder in iframe mode https://github.com/MakieOrg/Makie.jl/issues/2405

SimonDanisch commented 1 year ago

Hey, sorry I'm still stuck on merging #118, which should address quite a few of those issues... But maybe worth it to merge this anyways, I'll take a look tomorrow!

SimonDanisch commented 1 year ago

I'll close this for now, since it isn't really needed anymore, I think ;)