search

SimonDanisch / Bonito.jl

Serving JS to the browser
MIT License
204 stars 29 forks source link

enable logging requests #226

Closed bjarthur closed 4 months ago

bjarthur commented 4 months ago

HTTP.listen has an access_log argument. not sure why, but passing it into HTTP.Servers.Listener doesn't work.

the other commit in this PR simply fixes the carriage returns, and replaces some tabs with spaces.

SimonDanisch commented 4 months ago

Thank you! Any idea what happened to the diff? Looks like only small changes, but the diffs are very large

bjarthur commented 4 months ago

the diff of the entire PR is large b/c every line of src/HTTPServer/implementation.jl had a ^M at the end, unlike all other files in this repo. that might have been my fault from a previous PR. better to look at the diff of the three commits individually.

SimonDanisch commented 4 months ago

Ok, thanks! Looks good to me!