search

SimonDanisch / Bonito.jl

Serving JS to the browser
MIT License
204 stars 29 forks source link

fix relocatability #227

Closed bjarthur closed 1 week ago

bjarthur commented 3 months ago

needed these changes to move a PackageCompiler app from ~one ubuntu~ an oracle linux 9.2 box to ~another~ an ubuntu 22.04 box

bjarthur commented 3 months ago

somehow this PR breaks https://github.com/SimonDanisch/Bonito.jl/pull/226 ...

bjarthur commented 3 months ago

doh, nevermind, i had forgotten to rebase master. this PR is ready for review!

bjarthur commented 3 months ago

so certain assets, like the one below, are still not relocatable with this PR:

module Smiley

using Bonito, RelocatableFolders

function julia_main()::Cint
    display(smiley())
    return 0
end

function smiley()
    App() do
        DOM.div(DOM.img(src=Asset(@path joinpath(dirname(@__DIR__),"smiley.png"))))
    end
end

end
SimonDanisch commented 1 week ago

Closed in favor of https://github.com/SimonDanisch/Bonito.jl/pull/239