search

SimonDanisch / Bonito.jl

Serving JS to the browser
MIT License
204 stars 29 forks source link

throttle StylizedSlider #229

Closed bjarthur closed 2 months ago

bjarthur commented 3 months ago

copied throttle_function directly from WGLMakie and applied it to set_thumb just like WGLMakie does for resizing mouse events.

bjarthur commented 3 months ago

the error message when CI was building the docs is not very helpful: "Error: The operation was canceled."

bjarthur commented 3 months ago

tests now pass. ready for review. @SimonDanisch

bjarthur commented 2 months ago

hmmm... thinking on this further, it seems a shame to have such a large chunk of generally useful code duplicated. would it make sense to refactor WGLMakie to use this new copy of throttle_function in Bonito, or even to put throttle_function in WidgetsBase?

bjarthur commented 2 months ago

superseded by https://github.com/SimonDanisch/Bonito.jl/pull/233