search

SimonDanisch / Bonito.jl

Serving JS to the browser
MIT License
212 stars 31 forks source link

Error in `configure_server!` when `listen_port` not defined. #231

Open vpuri3 opened 4 months ago

vpuri3 commented 4 months ago

https://github.com/SimonDanisch/Bonito.jl/blob/ebba54d4445d5ff83879ed752ab8ae4a0bd1e4bc/src/server-defaults.jl#L125-L132

When listen_url is not defined, it is set to SERVER_CONFIGURATION.listen_url[] which is set to nothing. This trips the error in line 140 as follows:

julia> using Bonito

julia> Bonito.configure_server!()
ERROR: Trying to listen to nothing, while only "127.0.0.1", "0.0.0.0" and "localhost" are supported
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] configure_server!(; listen_url::Nothing, listen_port::Int64, forwarded_port::Int64, proxy_url::Nothing)
   @ Bonito ~/.julia/packages/Bonito/5OnJB/src/server-defaults.jl:140
 [3] configure_server!()
   @ Bonito ~/.julia/packages/Bonito/5OnJB/src/server-defaults.jl:118
 [4] top-level scope
   @ REPL[2]:1