use CLEANUP_TIME for closed 'hard' sessions too

SimonDanisch / Bonito.jl

Serving JS to the browser

MIT License

204 stars 29 forks source link

use CLEANUP_TIME for closed 'hard' sessions too #235

Closed bjarthur closed 1 month ago

bjarthur commented 2 months ago

fixes https://github.com/SimonDanisch/Bonito.jl/issues/234

bjarthur commented 2 months ago

i realize now that as-is this PR won't work because for "hard" sessions it will immediately close the server.

maybe CLEANUP_TIME would be best moved to the Session struct instead of being a global variable. then each session could have it's own independent value. ~~but there is one place where CLEANUP_TIME is used in which a Session is not available. not sure what to do there.~~

bjarthur commented 1 month ago

closed because i don't understand why there are two ways to close a websocket. hard and soft.