SimonDanisch / Bonito.jl

Serving JS to the browser
MIT License
204 stars 29 forks source link

WGLMakie example uses deprecated arg + unclear requirements and compat for examples #246

Open frankier opened 1 month ago

frankier commented 1 month ago

The WGLMakie example uses rotations which has been deprecated in Makie 0.21

https://github.com/SimonDanisch/Bonito.jl/blob/1a6083e84a660cc50e25bcd13349e3106cffcc7f/examples/wglmakie.jl#L29

In addition, it's not completely clear what the requirements are for the examples and which versions. For example it could have a Makie 0.20 compat in which case the above would not be a problem. Should the examples folder have an associated Project.toml?