SimonDedman / gbm.auto

Machine-learning Boosted Regression Tree software suite for species distribution modelling in R
https://doi.org/10.1371/journal.pone.0188955
Other
18 stars 6 forks source link

Map: Legend name in legend parameter in legend.grid #26

Open SimonDedman opened 6 years ago

SimonDedman commented 6 years ago

Label perspeciesareamap legend items w/ species names not 1:4 numbers (L387 & 402) legend <- c("Open", goodname), in legend.grid(), L61 of gbm.map. Hmm... gbm.map allows ... optionals to be passed to it but legend.grid is currently sealed ok end of gbm.map L61 add "..." to see if I'm allowed to add that to legend.grid DONE OK then run something which will call map & see if it breaks, e.g. baddata DONE OK if not, then try running baddata again with legend specified & see if it changes. valuemap L69 FAILS: if I pass 'legend' to gbm.map then in legend.grid it doesn't know whether to interpret the legend as legend the function or legend the parameter of legend the function. UNBELIEVABLY stupid parameter naming by legend function builders. Asked hans c("Open", goodname, recursive = TRUE) for later, if it's possible decompile hans code for legend.grid and build it back up manually thus passing legend(parameter) to legend (function) directly in legend.grid: 'type' populates 'legend' argument to legend function. change legend.grid so there's a type option to allow character strings change gbm.map L61 to call legend.grid with type = type change gbm.map arguments: add type = 2, in gbm.valuemap L387 & 402 add "type = goodname"