hapi v17 upgrade - Githubissues

SimonDegraeve / hapi-graphql

Create a GraphQL HTTP server with Hapi.

115 stars 27 forks source link

hapi v17 upgrade #23

Closed nover closed 6 years ago

nover commented 6 years ago

As requested in #21 this PR moves the plugin to node v8 and hapi v17:

completely removed babel (except for the eslint babel) as node 8 provides all the features built in (async / await + destructuring)
all dependencies upgrade
added unit-test using jest to show that:
- the plugin can cleanly register with hapi v17
- the graphql.org "hello world" schema works when registered via this plugin
- that the error handling on malformed queries is intact
update code to comply with the new hapi v17 contracts

nover commented 6 years ago

@SimonDegraeve I now have my feature branch successfully integrated in a project using hapi v17 - no problems so far with performing introspection and query execution.

tanepiper commented 6 years ago

@SimonDegraeve @nover Any chance of getting this released? 🥇

nover commented 6 years ago

@tanepiper I'm not a maintainer here so I am at the mercy of @SimonDegraeve

However you can install my fork directly in your project to test whether the changes work as expected: yarn add nover/hapi-graphql#feature/hapi-v17 - I'm pretty sure that it also works for npm

nover commented 6 years ago

@tanepiper due to lack of activity here I decided to fork and publish a new package with hapiv17 compatibility: https://github.com/skarpdev/hapi-graphql-2