search

SimonDegraeve / hapi-webpack-plugin

Webpack middleware for Hapi. Supports HMR.
57 stars 25 forks source link

Virtual Host Support #14

Open mashaalmemon opened 7 years ago

mashaalmemon commented 7 years ago

Hi @SimonDegraeve,

As mentioned in #13 I have modified plugin to support virtual hosts/route information if passed in. If no vhost specified passed in plugin behaves the same as before. Multiple instances of plugin, each for different vhost and different webpack configuration, are now supported.

Ultimately there are no breaking changes for past users, but new functionality for those wishing to support more complex setups with vhosts.

The readme has been updated accordingly.

Hopefully you can find some time push this one out soon. Let me know if you'd like me to modify adjust/anything further. I don't see any other changes being made to the plugin anytime soon (unless a bug is found).

mashaalmemon commented 7 years ago

@SimonDegraeve

Any feedback on this pull request?

mashaalmemon commented 7 years ago

Hi @SimonDegraeve ,

Just following up on this pull request. If you have any feedback, do you let me know.

If you could merge this in I think it would be helpful for others with more complex projects.

EyePulp commented 7 years ago

@mashaalmemon Thanks for the PR for vhosts, and thanks @SimonDegraeve for (possibly) merging it!