Closed huynmela closed 5 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/EOS.jl | 34 | 44 | 77.27% | ||
<!-- | Total: | 36 | 46 | 78.26% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/EOS.jl | 1 | 73.33% | ||
src/Crystal.jl | 3 | 66.9% | ||
src/Grid.jl | 4 | 77.73% | ||
src/Henry.jl | 5 | 82.2% | ||
src/GCMC.jl | 31 | 62.02% | ||
<!-- | Total: | 44 | --> |
Totals | |
---|---|
Change from base Build 407: | 0.03% |
Covered Lines: | 1137 |
Relevant Lines: | 1422 |
This had errors when running with julia 0.7 on travis build 426 that were not present in julia 1.0. I dropped support for julia 0.7 with this branch and added testing for julia 1.1
@huynmela looks great. Before merging, please:
.csv
files and skip the lines marked as a comment #
. See here for how to do so.when you put CSV 0.5.9
in the REQUIRE
file, does that mean CSV.jl has to be 0.5.9 version, or >0.5.9 is okay?
Having CSV 0.5.9
sets a floor for CSV at version 0.5.9, so anything >0.5.9 will also work
Revised EOS script to include VdW EOS along with modified VdW properties csv. Changed gas to fluid and modified docs to include VdW.