Fix dataframe mutation - Githubissues

SimonEnsemble / PorousMaterials.jl

Julia package towards classical molecular modeling of nanoporous materials

GNU General Public License v3.0

51 stars 11 forks source link

Fix dataframe mutation #121

Closed Surluson closed 4 years ago

Surluson commented 4 years ago

Previous version assumed the DataFrame being read in was mutable. This fix removes that assumption by changing the sort! function into sort (so the input argument doesn't get modified).

The tests have also been slightly modified to deal with immutable DataFrames.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 614

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.222%

Totals
Change from base Build 608:	0.0%
Covered Lines:	1156
Relevant Lines:	1441

SimonEnsemble / PorousMaterials.jl

Fix dataframe mutation #121

Pull Request Test Coverage Report for Build 614

💛 - Coveralls