search

SimonEnsemble / PorousMaterials.jl

Julia package towards classical molecular modeling of nanoporous materials
GNU General Public License v3.0
51 stars 11 forks source link

V0.4.0 #175

Closed eahenle closed 3 years ago

eahenle commented 3 years ago

Subsumes #173

Register as v0.4.0

eahenle commented 3 years ago

@SimonEnsemble ready for merge review

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e4e8ea2). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #175   +/-   ##
========================================
  Coverage          ?   0.00%           
========================================
  Files             ?      15           
  Lines             ?    1357           
  Branches          ?       0           
========================================
  Hits              ?       0           
  Misses            ?    1357           
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4e8ea2...28c96f7. Read the comment docs.

SimonEnsemble commented 3 years ago

looks good! just one small thing: I think global variables should be capitalized to signify that they are global in scope. (tho I guess for rc we are not) I checked the Julia style book again, and it actually doesn't mention this, but I know this is for Python and C. https://www.python.org/dev/peps/pep-0008/#constants what do you think? I think it's nice to have some way to signify to the coder that they are global variables instead of keeping it in your mind.