search

SimonEnsemble / PorousMaterials.jl

Julia package towards classical molecular modeling of nanoporous materials
GNU General Public License v3.0
50 stars 11 forks source link

fix incorrect path key #209

Closed eahenle closed 2 years ago

eahenle commented 2 years ago

partially addresses #208

still need CI testing on henry_coefficient

codecov-commenter commented 2 years ago

Codecov Report

Merging #209 (d34dfe3) into master (8900e17) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   56.79%   56.79%           
=======================================
  Files          15       15           
  Lines        1368     1368           
=======================================
  Hits          777      777           
  Misses        591      591
Impacted Files Coverage Δ
src/henry.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8900e17...d34dfe3. Read the comment docs.

eahenle commented 2 years ago

@CorySimon maybe we should disable the codecov/patch check? It doesn't seem too useful when combined with the /project check, and it fails a lot for questionable reasons.

PR is good to merge.