search

SimonEnsemble / PorousMaterials.jl

Julia package towards classical molecular modeling of nanoporous materials
GNU General Public License v3.0
51 stars 11 forks source link

rm done stuff from README #26

Closed SimonEnsemble closed 6 years ago

SimonEnsemble commented 6 years ago

@ahyork plz review. Sorry, I just copied the code from your adsorption_test branch and put it here and debugged it b/c I needed the function now for testing. It was easier to clone master and make a new branch than to try to figure out how to merge master into your adsorption_test branch which was behind.

SimonEnsemble commented 6 years ago

Sorry, the commit message is misleading. I added the stepwise_adsorption_isotherm function here plus documentation. Note the [@ref] that allows us to reference other functions in the docs!

ahyork commented 6 years ago

Sounds good! I will start working on the test suite so it is ready for summer.

Arthur

On Tue, Jun 5, 2018 at 11:15 AM, Cory Simon notifications@github.com wrote:

Sorry, the commit message is misleading. I added the stepwise_adsorption_isotherm function here plus documentation. Note the [@ref] that allows us to reference other functions in the docs!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SimonEnsemble/PorousMaterials.jl/pull/26#issuecomment-394808959, or mute the thread https://github.com/notifications/unsubscribe-auth/Af4qKl0cwiRjg_NnISrWygPV8YXNuI86ks5t5sq6gaJpZM4UbT7W .

-- -Arthur York

Class of 2021