SimonEnsemble / PorousMaterials.jl

Julia package towards classical molecular modeling of nanoporous materials
GNU General Public License v3.0
50 stars 11 forks source link

Ewald sum simplified into modular functions; GCMC now works for rotatable molecules #30

Closed SimonEnsemble closed 6 years ago

SimonEnsemble commented 6 years ago

:heavy_check_mark: runtests.jl pass :heavy_check_mark: timing in Ewald_test.jl 6 ms for electrostatic_potential_energy call :heavy_check_mark: SBMOF-1 Xe adsorption GCMC tests pass :white_check_mark: CO2 adsorption tests in ZIF-71 pass at low pressure (still waiting for higher pressures).

SimonEnsemble commented 6 years ago

I think even

function nearest_image!(dx::Array{Float64}, repfactors::Tuple{Int, Int, Int})
end

nearest_image!(dx::Array{Float64}) = nearest_image!(dx::Array{Float64}, (1,1,1))

will incur a performance penalty? Since we call it literally millions of times I figured we should take advantage of the simplification?