search

SimonEnsemble / PorousMaterials.jl

Julia package towards classical molecular modeling of nanoporous materials
GNU General Public License v3.0
51 stars 11 forks source link

Paths and Windows-compatibility #72

Closed Andrew-S-Rosen closed 6 years ago

Andrew-S-Rosen commented 6 years ago

Hi SimonEnsemble!

It seems that all the paths in PorousMaterials.jl are constructed via string concatenation. For greater inter-platform compatibility (notably, to enable compatibility with Windows machines), it's probably better to be constructing paths via joinpath, or a similar command. In my fork, I've searched through the code for all instances of path construction and have modified them with joinpath statements, so now it runs on my Windows machine (with all tests passing). If this of interest, I'll open a PR once I double-check I got them all. If not, feel free to close the issue.

SimonEnsemble commented 6 years ago

hi @arosen93, please do submit a pull request! I was not aware of this issue since I use Linux. I will start using joinpath for now on. joinpath("csimon" , "data", "crystals") gives the same result as string concatenation on my Linux machine.

Andrew-S-Rosen commented 6 years ago

Great! Will submit the PR tomorrow.