Eos 2 - Githubissues

SimonEnsemble / PorousMaterials.jl

Julia package towards classical molecular modeling of nanoporous materials

GNU General Public License v3.0

51 stars 11 forks source link

Eos 2 #77

Closed silsbyc96 closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 198

28 of 29 (96.55%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 87.529%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/EOS.jl	25	26	96.15%
<!--	Total:	28	29	96.55%	-->

Totals
Change from base Build 187:	0.2%
Covered Lines:	758
Relevant Lines:	866

💛 - Coveralls

SimonEnsemble commented 5 years ago

@silsbyc96 why all the 1 ./ rho's? Isn't rho a Float since you did rho = rho[argmin(rho)]? The . is for vectors, not needed for floats. also minimum(rho) is more clear.

SimonEnsemble commented 5 years ago

looks like @huynmela already had a compressibility_factor function we can overload. maybe I will overload that for the VdWGas