search

SimonEnsemble / PorousMaterials.jl

Julia package towards classical molecular modeling of nanoporous materials
GNU General Public License v3.0
51 stars 11 forks source link

function to determine if a given point is inside of a give box. #98

Closed SimonEnsemble closed 5 years ago

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 318

Totals Coverage Status
Change from base Build 311: 0.8%
Covered Lines: 954
Relevant Lines: 1573
💛 - Coveralls
SimonEnsemble commented 5 years ago

@ahyork any idea why the tests don't run anymore?

ahyork commented 5 years ago

I don't know why GitHub isn't showing the tests, but they are passing https://travis-ci.org/SimonEnsemble/PorousMaterials.jl/builds/458135294.

SimonEnsemble commented 5 years ago

@ahyork that would be awesome to add this function to the docs since it is useful. would you mind doing that? i'll take a look at your push so i can learn how it is done.

weird that travis isn't interfacing with github properly. let's see if the next fresh pull request will interface properly.

good thoughts for the test, but it is arbitrary if the points on the very edge are in the box or not (i.e. if we assign left to be in and right to be out or vice versa). in practice, a point will never lie exactly on the edge (except with extremeley small probability)-- at least for what i was using it for. unless you see a use case for that or where it would be necessary?

ahyork commented 5 years ago

Closing this because these changes are added in PR #99