search

SimonGoring / neotoma_paper

Repository for the neotoma package paper.
MIT License
3 stars 2 forks source link

Code editing #27

Closed gavinsimpson closed 10 years ago

gavinsimpson commented 10 years ago

Several fixes in the PR, which hopefully simplify the R code used in chunks.

  1. top.pinus was returning from two locations. This is not good (in general) form so I simplified this to a single (implicit) return
  2. use subset() for its intended purpose. Simplifies the subsetting for sample age and longitude
  3. Pandoc will sensibly render -- as an en dash, the correct typographical mark to separate two numbers.
  4. use transform() to simplify the coercion to factor
  5. minor indentation fix
SimonGoring commented 10 years ago

Sorry I missed this, at some point I'll get better. I'm closing this out. We've accounted for them in your last PR and in my latest commit 5ab108e98b5e3dd4e7fd88e656c80bc14fa2abb1.

gavinsimpson commented 10 years ago

No worries @SimonGoring - If it is any consolation, I had forgotten I'd made these changes, bar a little deja vu, until I came to do the new PR. Main thing is the changes got in in the end.