SimonGoring / neotoma_paper

Repository for the neotoma package paper.
MIT License
3 stars 2 forks source link

Remove explicit loading of knitr #28

Closed gavinsimpson closed 10 years ago

gavinsimpson commented 10 years ago

knitr is not needed by the reader to follow the paper or use neotoma so we shouldn't explicitly load it in the code chunks. Previously this would have broken the Makefile but now that knitr::kabel() is not used to render tables and we use knitr::opts_chunk$set() (i.e. explicitly reference the knitr namespace) we should be OK.

To fully round this out, the Makefile should be changed to load library("knitr") explicitly when calling Rscript, but I'll leave that for others to handle if they want.

There is some discussion of this point in #14.

karthik commented 10 years ago

I vote to merge.