Closed gavinsimpson closed 10 years ago
I'm fine with that!
OK; let me just confirm whether any of this needs the devel version and analogue and if not I'll make those changes. If it does need the devel version then I'll release a new version to CRAN and then make the changes.
Have you checked this out?
@SimonGoring Yes and it should be OK with 0.12-0 on CRAN. I'm just adding these locally to check with my current development version as I'm about to package that up for CRAN today. Will do a PR shortly if all is well with the changes I suggested above made.
I think we can close this one now following https://github.com/gavinsimpson/neotoma_paper/commit/e3d717858c5d2482eef3a97a8c142f11d68e49f7
In a couple of places you do some data manipulations which could be done more simply using
tran()
in the analogue package.could be done as
Later in same code block
could be done
Actually this is slightly different as this would retain species with 5% or greater.
Finally,
could be
This would require that analogue is loaded and might need me to push the version on Github to CRAN (but I don't think anything used here needs the new version) - which I'm happy to do in the next few days..