search

SimonHalvdansson / Harmonic-HN

Modern Android client for Hacker News
https://play.google.com/store/apps/details?id=com.simon.harmonichackernews
Apache License 2.0
611 stars 40 forks source link

Dialogs with discard button do not adhere to Material guidelines #136

Closed carstenhag closed 8 months ago

carstenhag commented 9 months ago

The "Discard comment?" dialog has the discard button on the left.
According to the Material guidelines, this shouldn't be the case. It is mentioned specifically as a Don't.

It should be checked whether other dialogs have the same issue.

https://m3.material.io/components/dialogs/guidelines

Screenshot_2023-12-11-22-37-29-499_com android chrome

Screenshot_2023-12-11-22-38-33-817_com simon harmonichackernews

carstenhag commented 9 months ago

Small note: sometimes when I just typed something in, IME still being visible, a back press makes this dialog show up. But more often, and imo expectedly so, first IME is closed. Only on a second back press, the dialog shows up.