search

SimonHalvdansson / Harmonic-HN

Modern Android client for Hacker News
https://play.google.com/store/apps/details?id=com.simon.harmonichackernews
Apache License 2.0
611 stars 40 forks source link

Early text cutoff when collapsed #138

Closed jonas-w closed 8 months ago

jonas-w commented 8 months ago

This comment https://news.ycombinator.com/item?id=38742339

Which just says "Macroexpand" gets cut off to "Macroexpan" when collapsed.

Screenshot_20231224_023304_Harmonic Screenshot_20231224_023314_Harmonic

As you can see the other comments get cut off later, except this one.

Just thought I'd share this, not really of any importance, but maybe this is of interest to you.

Again thank you for this great HN app!!

SimonHalvdansson commented 8 months ago

Huh yeah I tried this out and notices that the last character is always cut off! Typical off-by-one error I guess, will fix this. Thanks for bringing this to my attention!

SimonHalvdansson commented 8 months ago

Fixed by https://github.com/SimonHalvdansson/Harmonic-HN/commit/d8cbc90152d6058e51e91faa2b825b180e5f4d95, thanks again!

jonas-w commented 2 months ago

@SimonHalvdansson I don't know if this is related but I found another early text cutoff😅

https://news.ycombinator.com/item?id=40727389

Screenshot_20240619-154656 Screenshot_20240619-154707

But I don't know what I really would expect with links cutoff.