search

SimonHalvdansson / Harmonic-HN

Modern Android client for Hacker News
https://play.google.com/store/apps/details?id=com.simon.harmonichackernews
Apache License 2.0
611 stars 40 forks source link

Close #135, Filter stories less than x points #140

Closed naitgacem closed 8 months ago

naitgacem commented 8 months ago

This is still a work in progress and would like feedback. I have added the preference and the setting works initially.

The issue is that we are removing stories from the queue after the data comes back.

There arrives a point where we have eliminated the entire queue due to for example a filter score too high. And we only load more stories in the onScrolled(). So we practically reach a dead end. This is also glaringly visible when the filter was applied to types such as Ask HN where stories count is low.

Perhaps we should fetch more stories based on the number of stories visible rather than onScrolled() only?

naitgacem commented 8 months ago

It appears Top, New, Best, Ask, Show and Job from the HN API only serves 200 or 500 top posts. So not much one can do about those.