search

SimonHalvdansson / Harmonic-HN

Modern Android client for Hacker News
https://play.google.com/store/apps/details?id=com.simon.harmonichackernews
Apache License 2.0
627 stars 41 forks source link

Search locally askHN comments #148

Closed trySometngNew closed 9 months ago

trySometngNew commented 10 months ago

Hi Simon, Will it be possible to add in app local search functionality within askHN post to search word or phrase in all comments under the askHN post? This should work and be used like "Search Page" browser functionality (#102)

Regards, Sourabh

trySometngNew commented 10 months ago

Hi @SimonHalvdansson, Sorry, forgot to tag you.

SimonHalvdansson commented 9 months ago

How is this different from https://github.com/SimonHalvdansson/Harmonic-HN/issues/102 exactly? I think I'm missing something

trySometngNew commented 9 months ago

Hi @SimonHalvdansson, AskHN posts do not have local search functionality it seems.

SimonHalvdansson commented 9 months ago

Ah I see, I made it so the "More" button always shows now instead https://github.com/SimonHalvdansson/Harmonic-HN/commit/35e2c87dac4862a9735426ab8919e70c7200a334